Repository navigation
gh-160239: Remove dead _repr_info() methods from asyncio.windows_events - #160241
Merged
Merged
Conversation
…s_events Future.__repr__() now uses base_futures._future_repr() instead of _repr_info(), so these overrides are dead and their super()._repr_info() call would raise AttributeError.
OsmnvAslan
marked this pull request as ready for review
October 22, 2026 14:19
OsmnvAslan
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
October 22, 2026 14:19
This comment has been minimized.
This comment has been minimized.
kumaraditya303
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the two dead
_repr_info()overrides from_OverlappedFutureand_BaseWaitHandleFutureinasyncio.windows_events.Future.__repr__()now usesbase_futures._future_repr()(gh-42183), so these overrides are never called, and theirsuper()._repr_info()call would raiseAttributeErrorbecauseFutureno longer defines_repr_info().Closes gh-160239.
Prepared with AI assistance, then reviewed and tested before submission.