Skip to content

gh-160381: Show LLVM profile statistics after PGO training - #160373

Merged
itamaro merged 1 commit into
python:mainfrom
zanieb:pbs/pgo-statistics-upstream
Oct 23, 2026
Merged

itamaro merged 1 commit into
python:mainfrom
zanieb:pbs/pgo-statistics-upstream

Conversation

@zanieb

@zanieb zanieb commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

LLVM PGO builds merge the training profiles without showing the profile-count distribution or functions with the hottest basic blocks. Run llvm-profdata show --detailed-summary --topn=500 after merging to make it easier to compare training workloads.

Addresses astral-sh/python-build-standalone#1033 tracking upstreaming of this patch.

@corona10

corona10 commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Would you like to create an issue first and link it?
You can simply assign it to yourself when you create it, if other factors matter.

@zanieb

zanieb commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

I don't think an issue matters here? This is a trivial convenience change for developers.

@zanieb

zanieb commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

What are you considering the bar for opening an issue?

@zanieb zanieb changed the title Show LLVM profile statistics after PGO training gh-160381: Show LLVM profile statistics after PGO training Oct 22, 2026
@zanieb zanieb removed the skip issue label Oct 22, 2026
@picnixz

picnixz commented Oct 22, 2026

Copy link
Copy Markdown
Member

What are you considering the bar for opening an issue?

Usually, when something can break on machines because of personal configurations (or lacking features) or if we need to remove it later or improve it later. It's sometimes just good to have an issue for announcing the change with a NEWS entry (so just for having a number associated).

I added the feature tag and you will need an approval from a core dev for that but I can approve it because I think it makes sense.

Comment thread configure.ac
@zanieb

zanieb commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

--topn shipped in LLVM 5.0 in 2017

@picnixz

picnixz commented Oct 22, 2026

Copy link
Copy Markdown
Member

!buildbot PGO

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 730f2f6 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F160373%2Fmerge

The command will test the builders whose names match following regular expression: PGO

The builders matched are:

  • AMD64 Fedora Rawhide LTO + PGO PR
  • AMD64 Windows PGO NoGIL Tailcall PR
  • aarch64 CentOS9 LTO + PGO PR
  • AMD64 CentOS9 LTO + PGO PR
  • s390x Fedora Rawhide LTO + PGO PR
  • AMD64 CentOS10 LTO + PGO PR
  • AMD64 Windows PGO NoGIL PR
  • aarch64 Fedora Rawhide LTO + PGO PR
  • AMD64 Windows PGO Tailcall PR
  • s390x Fedora Stable LTO + PGO PR
  • aarch64 Fedora Stable LTO + PGO PR
  • AMD64 Windows PGO PR
  • PPC64LE Fedora Rawhide LTO + PGO PR
  • AMD64 Fedora Stable LTO + PGO PR
  • aarch64 CentOS10 LTO + PGO PR
  • PPC64LE CentOS9 LTO + PGO PR
  • s390x RHEL9 LTO + PGO PR
  • s390x CentOS10 LTO + PGO PR
  • PPC64LE Fedora Stable LTO + PGO PR

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@itamaro
itamaro merged commit 39ea54a into python:main Oct 23, 2026
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build The build process and cross-build skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants