Repository navigation
gh-160406: Keep the backup and create output exclusively in fileinput - #160407
Merged
Merged
Conversation
…einput In-place filtering deleted the backup file, the only copy of the data, when the output file could not be created. An existing backup file is now only replaced once there is a file to back up, so trying again does not delete it either. The output file is now created with O_EXCL and its mode is set through the file descriptor.
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileInput.nextfile()no longer deletes the backup file when no output file was created, since the backup is then the only copy of the data (for example when the input file cannot be opened for reading), and an existing backup is now replaced withos.replace()instead of being unlinked first, so running the same command again does not delete it either. The output file is now created withO_EXCL('x'mode in thefstat()failure fallback) and its mode is set through the file descriptor whereos.chmod()supports that, so a file or symlink that appears under the input file's name after the rename raisesFileExistsErrorinstead of being written through and chmodded.The
FileExistsErroris a behaviour change, documented with aversionchanged. After a failure the data is left in<name>.bakrather than renamed back, because renaming back could replace whatever now has the name.Fixes #160406
ANT-2026-3TZS4H87
fileinputin-place filtering deletes the file when it cannot be opened #160406