Repository navigation
[3.14] gh-128883: Store ELF perf trampoline templates in read-only data (GH-160366) - #160492
Merged
Merged
Conversation
…nly data (pythonGH-160366) CPython copies the trampoline templates into executable memory. Keep the ELF source in .rodata so BOLT preserves its bytes and boundaries. (cherry picked from commit 1ff83ad) Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #160366 to 3.14.
BOLT can change perf trampoline templates in executable sections and cause crashes. Store the ELF templates in
.rodata, with the change inPython/asm_trampoline.Sfor this branch.(cherry picked from commit 1ff83ad)