Repository navigation
gh-160511: Ignore configured proxies in test_urllib.urlopen_HttpTests - #160512
Open
devdavidejesus wants to merge 1 commit into
Open
devdavidejesus wants to merge 1 commit into
devdavidejesus wants to merge 1 commit into
Conversation
…pTests Two tests failed when https_proxy was set, because urlopen() then tunnels through the proxy and the invalid host is rejected later with ValueError (or URLError if the proxy is unreachable) instead of InvalidURL. Make getproxies() return no proxies in these tests and reset the cached opener.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urlopen_HttpTests.setUp()now replacesurllib.request.getproxieswith one that returns no proxies, and resets the module-level opener before and after each test, so a proxy from the environment or the macOS system settings, or an opener built by an earlier test, no longer changes the result.Test-only change, so no NEWS entry.
Tested with a pydebug build of main on macOS:
https_proxyset (alone, or withhttp_proxy),-m test test_urllibfails without the change (2 errors) and passes with it.-R 3:3(withhttps_proxyset) reports no leaks.test_urllib2andtest_urllib2_localnetpass.See #160511.