Repository navigation
[3.14] gh-160491: Fix location of invalid escapes in f-strings and t-strings (GH-160493) - #160531
Merged
Merged
Conversation
…trings (pythonGH-160493) Literal parts of f-strings and t-strings are decoded only after the whole string has been parsed, so a decode error took the location of the last token. The resulting SyntaxError pointed at the closing quote, and for multi-line strings it could be on the wrong line. Raise the error at the literal part being decoded instead. (cherry picked from commit 2258026) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
miss-islington
requested review from
lysnikolaou and
pablogsal
as code owners
October 23, 2026 22:29
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Literal parts of f-strings and t-strings are decoded only after the
whole string has been parsed, so a decode error took the location of
the last token. The resulting SyntaxError pointed at the closing quote,
and for multi-line strings it could be on the wrong line.
Raise the error at the literal part being decoded instead.
(cherry picked from commit 2258026)
Co-authored-by: Lysandros Nikolaou lisandrosnik@gmail.com