Repository navigation
Conversation
ivonastojanovic
approved these changes
Oct 24, 2026
ivonastojanovic
left a comment
ivonastojanovic
left a comment
Contributor
There was a problem hiding this comment.
LGTM! This should also fix #160334.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collapsed-export format check rejects
<unreadable frame>,<GC>, and<native>because these entries have no colon. The check now accepts those labels and retains the format requirement for ordinary entries.The subprocess readiness check expects the executable name
sleep, which causes a timeout when BusyBox provides the command. Compare executable file identity instead, so the check still waits forexec().Fixes #160529.
test_profilingis flaky #160529