Repository navigation
[3.11] gh-160040: Distrust compromised eMudhra intermediate CA keys (CVE-2026-115557) (GH-160042) - #160572
Merged
Conversation
…keys (CVE-2026-115557) (pythonGH-160042) The ssl module now rejects TLS certificate chains that contain any of a set of compromised eMudhra intermediate CA keys. This is an extraordinary measure and a last line of defense: removing trust is primarily the job of the platform root store, and the built-in denylist only blocks connections while that update has not yet reached the OS, a container image, or a bundled trust store in various Python packages. Entries are added to the denylist only under a very high threshold. The denylist matches on the public key (the SHA-256 digest of the RFC-5280 SubjectPublicKeyInfo), so it also covers the cross-signed certificates that reuse one of the distrusted keys. --------- Signed-off-by: Christian Heimes <christian@python.org> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit 7dd8b47) Co-authored-by: Christian Heimes <christian@python.org>
This was referenced Oct 24, 2026
gpshead
marked this pull request as ready for review
October 24, 2026 07:12
Contributor
|
The Windows failure is because the NuGet host Python is now 3.15.1, which dropped Loader.load_module(), but 3.11's makeopcodetargets.py still relies on it. This is an infra failure unrelated to this backport and can be dealt with separately. |
Contributor
|
Land #160621 first, then merge 3.11 into this PR. |
github-project-automation
Bot
moved this from Todo
to Done
in Release and Deferred blockers 🚫
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 7dd8b47)
Co-authored-by: Christian Heimes christian@python.org
Manual backport notes (3.11):
Modules/_ssl.c: 3.11 predates _ssl.c calls SSL_CTX_get_verify_callback unnecessarily #113332, so_set_verify_mode()still fetched and re-installed the current ctx verify callback. It now installs_ssl_verify_callbackdirectly, as on main (the unusedverify_cblocal is dropped; CPython never installs a callback of its own).newPySSLSocket()'s post-handshake-auth path already passesSSL_get_verify_callback()through, which inherits the ctx callback, so only main's comment is added there.Lib/test/test_ssl.py: 3.11 lacks main'sLEAF_MISSING_AKI_*constants; theDISTRUSTED_SPKI_*block is placed afterSIGNED_CERTFILE_ECC_HOSTNAME. The test itself is unchanged.Lib/test/certdata/make_ssl_certs.py: 3.11 predates the argparsecmdlineargsrefactor, somake_distrusted_spki_cert()takes no arguments and uses the module-levelenddateand literal'7000'days like the rest of the 3.11 script.Makefile.pre.in/PCbuild/_ssl.vcxproj{,.filters}: add onlyModules/_ssl/distrusted_spki.h(main's_openssl_mem.his main-only), plus theHeader Filesfilter definition.distrusted_spki.h,distrusted.zipand the NEWS entry are identical to main.test_sslandtest_asynciopass (along with the other ssl-using stdlib tests), includingtest_distrusted_spki;_ssl.ccompiles warning-free with-Wall -Wextra.