Repository navigation
Accept UTF-8 byte-order marks in OBJ and material files - #158
Open
civilwarinfrance wants to merge 1 commit into
Open
civilwarinfrance wants to merge 1 commit into
civilwarinfrance wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A UTF-8 byte-order mark at the start of an OBJ or MTL file becomes part of its first statement (
vornewmtl). This can omit the first vertex/material, fail face loading, or raise an unimplemented-statement error in strict mode.Resolve UTF-8 encoding aliases to the standard
utf-8-sigdecoder when opening plain or gzip files. It consumes only the initial signature; U+FEFF inside a material name remains intact. Keep the requested encoding setting and non-UTF-8 decoding unchanged. Document the behavior.Validation on macOS/CPython 3.11.15:
git diff --checkpasses.No dependencies are added. The older CI Python/OS matrix and rendering were not run locally.
AI assistance: OpenAI Codex prepared and tested this contribution.