Repository navigation
Preserve material opacity when parsing RGB colors - #159
Open
civilwarinfrance wants to merge 1 commit into
Open
civilwarinfrance wants to merge 1 commit into
civilwarinfrance wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MTL RGB color statements replace the stored alpha with zero. As a result, a default-opaque
Kdcolor gets alpha 0, andd 0.25beforeKdgives a different result from the same statements in reverse order.When a parsed Ka/Kd/Ks/Ke color omits alpha, supply the current material opacity. Keep the public Material color setters and existing explicit RGBA behavior unchanged. This also preserves opacity for abbreviated colors without changing their existing RGB interpretation.
The Alias/Wavefront material manual permits statements in any order and defines default dissolve as fully opaque.
Validation on macOS/Python 3.11.15:
git diff --checkpasses.No dependency or rendering changes. GPU output and the legacy platform/Python matrix were not tested.
AI assistance: OpenAI Codex prepared and tested this contribution.