Skip to content

fix: [indicator] default the fallback label to the accent variant - #982

Open
Shreyag02 wants to merge 1 commit into
fix/token-valuesfrom
fix/indicator-fallback-label
Open

Shreyag02 wants to merge 1 commit into
fix/token-valuesfrom
fix/indicator-fallback-label

Conversation

@Shreyag02

Copy link
Copy Markdown
Contributor

Summary

  • Without variant, the badge's fallback aria-label was "undefined indicator". It now uses accent, the cva default.

  • With variant={null}, the label was "null indicator" and the badge had no variant class. Both now use accent.

  • I have followed the pull request section of the contributing guide.

@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
apsara Ready Ready Preview Oct 19, 2026 10:59am UTC

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 81d54753-ead5-4669-9561-6b62939358a9
📥 Commits

Reviewing files that changed from the base of the PR and between 7dcdf39 and 051b0da.

📒 Files selected for processing: 2
  • packages/react/components/indicator/__tests__/indicator.test.tsx
  • packages/react/components/indicator/indicator.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/@raystack/apsara@982

commit: 051b0da

@Shreyag02
Shreyag02 changed the base branch from main to fix/token-values October 22, 2026 05:32
@Shreyag02
Shreyag02 added this pull request to stack #986 October 22, 2026 05:32

This branch was successfully deployed

1 active deployment
Preview — 051b0da7 Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant