Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125706316. |
Summary: `-[RCTInstance invalidate]` held `_invalidationMutex` while it synchronously called `[_surfacePresenter suspend]`. Stopping surfaces notifies mount observers on the calling thread, and any observer that reaches `callFunctionOnJSModule:` (e.g. `RCTLog` forwarding to JS in debug builds) blocks forever on the same non-recursive mutex. Release the mutex after setting `_valid = false` and unregistering from the inspector, before `suspend`. Re-entrant calls now see `!_valid` and return. Changelog: [iOS][Fixed] - Fix deadlock in `RCTInstance` invalidation when a surface observer calls into JS Reviewed By: javache Differential Revision: D125706316
zeyap
force-pushed
the
export-D125706316
branch
from
October 16, 2026 21:41
4751171 to
af9a25a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
-[RCTInstance invalidate]held_invalidationMutexwhile it synchronously called[_surfacePresenter suspend]. Stopping surfaces notifies mount observers on the calling thread, and any observer that reachescallFunctionOnJSModule:(e.g.RCTLogforwarding to JS in debug builds) blocks forever on the same non-recursive mutex.Release the mutex after setting
_valid = falseand unregistering from the inspector, beforesuspend. Re-entrant calls now see!_validand return.Changelog:
[iOS][Fixed] - Fix deadlock in
RCTInstanceinvalidation when a surface observer calls into JSReviewed By: javache
Differential Revision: D125706316