Repository navigation
Type structuredClone typed arrays as ArrayBuffer-backed - #59147
Closed
SamChou19815 wants to merge 1 commit into
Closed
SamChou19815 wants to merge 1 commit into
SamChou19815 wants to merge 1 commit into
Conversation
Summary: `cloneTypedArray` passes `value.buffer` to `cloneArrayBuffer(value: ArrayBuffer)`. With TypeScript's ES2024 `ArrayBuffer` definitions, `$TypedArray` (meaning `$TypedArray<ArrayBufferLike>`) has an `ArrayBufferLike` buffer, which is no longer an `ArrayBuffer`. Hermes, React Native's default engine, has no `SharedArrayBuffer`, and `cloneArrayBuffer` already treats its input and its `slice(0)` copy as an `ArrayBuffer`. This narrows `isTypedArray`'s refinement and `cloneTypedArray`'s parameter to `$TypedArray<ArrayBuffer>`. It is a type-only change. Changelog: [Internal] Differential Revision: D125721761
meta-cla
Bot
added
the
CLA Signed
|
@SamChou19815 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125721761. |
|
This pull request has been merged in 96dddb0. |
Collaborator
|
This pull request was successfully merged by @SamChou19815 in 96dddb0 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
cloneTypedArraypassesvalue.buffertocloneArrayBuffer(value: ArrayBuffer). With TypeScript's ES2024ArrayBufferdefinitions,$TypedArray(meaning$TypedArray<ArrayBufferLike>) has anArrayBufferLikebuffer, which is no longer anArrayBuffer. Hermes, React Native's default engine, has noSharedArrayBuffer, andcloneArrayBufferalready treats its input and itsslice(0)copy as anArrayBuffer. This narrowsisTypedArray's refinement andcloneTypedArray's parameter to$TypedArray<ArrayBuffer>. It is a type-only change.Changelog: [Internal]
Differential Revision: D125721761