Repository navigation
fix(js): send the reporter's own events through the client report - #685
Conversation
reportInvalidUpdateOnce and emitError called the reporter's report directly after #684, so a replaced or spied client.report missed them; before the split both went through this.report. The reporter now raises them through its host's report, like every other part of the client. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Bump package.json and harmony/pushy/oh-package.json5 together, with the bilingual release notes. Ships everything since 10.60.0: the shared native round engine (#673-#681), the cross-platform alignment and fixes (#664, #666, #671, #687, #688), the JS client fixes and split (#667, #684, #685), the bounded host prepareBundle (#669), the generated cross-platform contract (#683, #686) and the trimmed npm package (#670). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
#684 的 CodeRabbit 意见:拆分后
reportInvalidUpdateOnce和emitError直接调用了 Reporter 自己的report。如果有人在实例上替换或 spy 了client.report,就收不到这两类事件。拆分前它们都经由this.report,这违背了那个 PR 里写明的规则:调用公开成员一律经由 client 实例。现在 Reporter 通过 host 的
report发出这两类事件,client.ts把 host 的report接到client.report。新增回归测试:spy
client.report后,emitError和reportInvalidUpdateOnce的事件都能被观察到。去掉修复后这个测试失败。bun run lint通过,bun test459 个用例全部通过。🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit