Repository navigation
fix: convert case-insensitive style attributes - #2452
Merged
remarkablemark merged 1 commit intoOct 20, 2026
Merged
remarkablemark merged 1 commit into
remarkablemark merged 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2452 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 144 145 +1
Branches 55 56 +1
=========================================
+ Hits 144 145 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Allow valid HTML with uppercase or mixed-case
styleattributes to render on the server.What is the current behavior?
renderToStaticMarkup(parse('<p STYLE="color: red">Hello</p>'))throws becausestyleis left as a string. The attribute name is normalized, but style conversion only reads the original lowercaseattributes.style.What is the new behavior?
Convert the style value after its attribute name is normalized. Unit and SSR regressions cover
style,STYLE, andStYlE; the uppercase/mixed-case cases fail on the original code.Checklist:
Build, ESLint, and package lint also passed. Chromium and WebKit each passed 146 tests. The Firefox suite could not start locally: its browser-session connection timed out before any tests ran.
AI disclosure: OpenAI Codex implemented the change and ran the checks; a separate AI agent independently reviewed the final patch.