Repository navigation
Port selected upstream OCaml type checker improvements (post 4.06) #9130
Copy link
Copy link
Open
Description
The type checker and pattern-match compiler in compiler/ml are a 4.06-era fork of OCaml. They have diverged a lot since then. Upstream has made several improvements in the meantime that would help ReScript users directly. This issue tracks the ones worth porting by hand. A full resync is not a goal.
Candidates, by value
- Diff-based inclusion errors (4.13,
Diffing). Signature mismatches name the record field or variant constructor that was added, removed, swapped or renamed, and the same goes for functor arguments. Today we print "Their kinds differ" or "Fields number N have different names"..resimismatches are common, and the change stays mostly withinincludecore/includemod. It needs a port by hand, because of our own error cases (Field_optional,Runtime_annotation,Not_undefined, …). - Shapes (4.14).
.cmtfiles record where each definition comes from, through functor applications,includeand module aliases. This would remove the analysis limitation for cross-file references through applied functors (see Use the applied signature for modules created by functor application #9084). It is also the basis for project-wide find-references. Requires a cmt format change. - Matching on mutable fields under guards (upstream Pattern matching with mutable and lazy patterns is unsound ocaml/ocaml#7241, unsound). We are affected: a failed guard that changes a mutable field can make
switchtake a case that does not match. Repro and details in switch can take a non-matching case after a guard mutates the scrutinee #9129. Upstream fixed it in OCaml 5.3 (The Pattern-Matching Bug: propagate mutability of argument positions ocaml/ocaml#13138, The Pattern-Matching Bug: fix totality information ocaml/ocaml#13152). - Warning names (4.12). Accept names like
+unused-varnext to numbers in-wand inrescript.json. Cheap to add, and warning configs become readable. -
Parmatchimprovements. These can be picked one at a time. Counterexamples mention guarded clauses ("some guarded clause may match this value"). Unused cases inside or-patterns are detected more precisely. Refutation is faster. - Structured unification traces (
Errortrace, 4.14/5.0). These separate unification, equality and moregen failures, which gives more precise "not compatible" explanations. We have already rewritten many messages (error_message_utils), so the gain is smaller and touches more code. - Type scopes (4.08–4.11). Escape checks for locally abstract types and first-class modules would use a separate scope instead of levels. This is invasive (
ctype/typecore), so only worth it if escape bugs come up. - GADT soundness fixes (injectivity, 4.12, and others). Port these when a bug report needs one. GADTs are rare in ReScript code.
Out of scope
- Abstract
type_expr(4.14) and thewith_local_levelrefactor (5.1): a lot of churn, no user-visible gain. - Upstream error rendering (
Location.report): we have our owncode_frame. - Lambda/Simplif optimisations and Flambda: the JS backend has its own
Lampasses. - Language features that don't fit ReScript: binding operators, labeled tuples, effects, unboxed layouts and modes,
with module type. - Alerts (
[@alert]): would only be nice to have unless there is demand for categories beyond@deprecated.
Each checked item should be its own PR with tests and a changelog fragment where users can see the change.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Activity
fhammerschmidt commentedon Oct 29, 2026
Diff-based signature errors and warning names would be great to have!