Repository navigation
Conversation
|
Semantic Diff viewer of this pull request: https://cdn.rescript-lang.org/semantic-diff/view/pr-8962/index.html?pr=8962 |
Semantic Diff1 commit · Full page Draw any pull request's records in the browser8fd1816 · Christoph Knittel with Claude Opus 5.5 · Oct 22, 2026 A Semantic Diff page exists only for a pull request the workflow rendered, and shows its latest push. The viewer reads a pull request's, a range's or commits' records from GitHub's API and draws them with the page's renderer, at most 250 commits; a workflow publishes it to the CDN from master, and from a pull request that changes it under its own address. |
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8962 |
A Semantic Diff page exists only for a pull request the workflow rendered, and shows its latest push. The viewer reads a pull request's, a range's or commits' records from GitHub's API and draws them with the page's renderer, at most 250 commits, with the authors' GitHub logins and the dates in UTC as the cards print them; a workflow publishes it to the CDN from master, and from a pull request that changes it under its own address. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp Claude-Session: https://claude.ai/code/session_01Kr4cjoUi2f5VpMvE6wT9bo Signed-off-by: Christoph Knittel <ck@cca.io>
8fd1816 to
c129a4a
Compare
ChangelogNo changelog entry. Semantic Diff1 commit · Full page ✏️ Draw any pull request's records in the browserc129a4a · cknitt + Claude · Oct 22, 2026, 15:53 UTC · edited A Semantic Diff page exists only for a pull request the workflow rendered, and shows its latest push. The viewer reads a pull request's, a range's or commits' records from GitHub's API and draws them with the page's renderer, at most 250 commits, with the authors' GitHub logins and the dates in UTC as the cards print them; a workflow publishes it to the CDN from master, and from a pull request that changes it under its own address. |
Follow-up to #8958 and #8957: instead of only the page the workflow renders for each push, a viewer page draws the commit records of any pull request, range or commit in the browser, reading them from GitHub's API and drawing them with the same renderer (
recordRender.js, which has no Node dependencies).scripts/recordViewer.jsmaps the query to API calls (/pulls/N,/pulls/N/commits,/compare/a...b,/commits/sha), leaves out merge commits likerev-list --no-merges, and drawspageBodyinto the page;scripts/recordViewer.htmlis the page..or/(shas, tags, branches), so a query can't point the request at another API path. Commit messages are drawn through the renderer's escaping, as on the existing pages..github/workflows/semantic_diff_viewer.ymlpublishes the viewer tosemantic-diff/view/on a push to master. A pull request from a branch of this repository that changes the viewer or the renderer publishes its own copy undersemantic-diff/view/pr-<N>/and comments the address, so this PR can be tried before it lands. Files are served withCache-Control: max-age=300.Oct 23, 2026, 14:41 UTC), and the author's GitHub login as a profile link when the API knows the account.The existing per-push pages and Markdown comments are unchanged. A possible next step: link each comment to
?pr=N&range=<base>...<head>, which redraws exactly that push even after later pushes.New tests:
scripts/recordViewer.test.js(query to API calls against a fake API, pagination, limits, malformed queries), added toyarn test-commit-records.🤖 Generated with Claude Code
https://claude.ai/code/session_01AzPS5F8RDSGZ6dhfK6NdZp