Repository navigation
Fix the master build: add the blank line that #8961 prints to the comment pattern snapshot - #9137
Merged
Merged
Conversation
…pshot #9127 added list-pattern cases to printer/comments/pattern.res, and its snapshot was made before #8961, which puts a blank line around multi-line module items, was merged. Together they print a blank line before `let f = x => switch x {…}`, and the syntax test of master has failed on it since #9127. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gLpf7RN1MiRcubPgRn Signed-off-by: Christoph Knittel <ck@cca.io>
ChangelogNo changelog entry. Semantic Diff1 commit · Full page Add the blank line before a multi-line let to the comment pattern snapshot9e566ed · cknitt + Claude · Oct 30, 2026, 07:58 UTC #9127 added list-pattern cases to printer/comments/pattern.res, and its snapshot was made before #8961, which puts a blank line around multi-line module items, was merged. Together they print a blank line before |
cknitt
enabled auto-merge (squash)
October 30, 2026 08:07
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9137 +/- ##
==========================================
- Coverage 81.72% 81.72% -0.01%
==========================================
Files 460 460
Lines 64814 64817 +3
==========================================
- Hits 52970 52969 -1
- Misses 11844 11848 +4 🚀 New features to boost your workflow:
|
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-9137 |
fhammerschmidt
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master's CI has failed on every platform since #9127: the syntax test prints a blank line in
tests/syntax_tests/data/printer/comments/expected/pattern.res.txtthat the snapshot lacks.#9127 added list-pattern cases to
printer/comments/pattern.resand generated the snapshot before #8961 was merged. #8961 puts a blank line around multi-line module items, so together they print one beforelet f = x => switch x {…}. The printer is right, the snapshot is stale.The syntax test failing first also kept the later CI steps from running on master since then. I ran them on master locally (unit, mocha, build, docstring, analysis and reanalyze tests); they pass, so this snapshot is the only fix needed.
No changelog fragment: test-only change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Kbf3gLpf7RN1MiRcubPgRn