Skip to content

Fix the master build: add the blank line that #8961 prints to the comment pattern snapshot - #9137

Merged
cknitt merged 1 commit into
masterfrom
fix-pattern-snapshot
Oct 30, 2026
Merged

cknitt merged 1 commit into
masterfrom
fix-pattern-snapshot

Conversation

@cknitt

@cknitt cknitt commented Oct 30, 2026

Copy link
Copy Markdown
Member

Master's CI has failed on every platform since #9127: the syntax test prints a blank line in tests/syntax_tests/data/printer/comments/expected/pattern.res.txt that the snapshot lacks.

#9127 added list-pattern cases to printer/comments/pattern.res and generated the snapshot before #8961 was merged. #8961 puts a blank line around multi-line module items, so together they print one before let f = x => switch x {…}. The printer is right, the snapshot is stale.

The syntax test failing first also kept the later CI steps from running on master since then. I ran them on master locally (unit, mocha, build, docstring, analysis and reanalyze tests); they pass, so this snapshot is the only fix needed.

No changelog fragment: test-only change.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Kbf3gLpf7RN1MiRcubPgRn

…pshot

#9127 added list-pattern cases to printer/comments/pattern.res, and its
snapshot was made before #8961, which puts a blank line around multi-line
module items, was merged. Together they print a blank line before
`let f = x => switch x {…}`, and the syntax test of master has failed on it
since #9127.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Kbf3gLpf7RN1MiRcubPgRn
Signed-off-by: Christoph Knittel <ck@cca.io>
@cknitt cknitt added the changelog:skip No release notes needed label Oct 30, 2026
@github-actions

Copy link
Copy Markdown

Changelog

No changelog entry.

Semantic Diff

1 commit · Full page

Add the blank line before a multi-line let to the comment pattern snapshot

9e566ed · cknitt + Claude · Oct 30, 2026, 07:58 UTC

#9127 added list-pattern cases to printer/comments/pattern.res, and its snapshot was made before #8961, which puts a blank line around multi-line module items, was merged. Together they print a blank line before let f = x => switch x {…}, and the syntax test of master has failed on it since #9127.

@cknitt cknitt changed the title Add the blank line before a multi-line let to the comment pattern snapshot Fix the master build: add the blank line that #8961 prints to the comment pattern snapshot Oct 30, 2026
@cknitt
cknitt enabled auto-merge (squash) October 30, 2026 08:07
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.72%. Comparing base (2303933) to head (9e566ed).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9137      +/-   ##
==========================================
- Coverage   81.72%   81.72%   -0.01%     
==========================================
  Files         460      460              
  Lines       64814    64817       +3     
==========================================
- Hits        52970    52969       -1     
- Misses      11844    11848       +4     

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Oct 30, 2026

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@9137

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@9137

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@9137

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@9137

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@9137

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@9137

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@9137

commit: 9e566ed

@github-actions

Copy link
Copy Markdown

@cknitt
cknitt merged commit 25e3dfb into master Oct 30, 2026
26 of 27 checks passed
@cknitt
cknitt deleted the fix-pattern-snapshot branch October 30, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip No release notes needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants