Repository navigation
Bound CLI benchmarks without background kills - #1528
Merged
Merged
Conversation
A fixed-count benchmark can finish before its delayed kill command fires, leaving it able to terminate a later CLI invocation. The Windows timer targets every `river.exe`, so a following migration can exit silently while the benchmark step reports success. Use `--duration 10s` to bound the timed benchmark and let the fixed-count benchmark finish normally on both platforms. Remove the forced kills and `|| exit 0` so commands shut down cleanly and benchmark errors fail the job.
brandur
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixed-count CLI benchmark can finish before its background ten-second kill timer fires. On Windows,
taskkill /F /IM river.exe /Tcan then terminate a later CLI invocation. In this failing Windows job, the benchmark finishes at 23:08:45 UTC and the custom-schemamigrate-downexits silently at 23:08:53 UTC, ten seconds after the timer starts.Use
--duration 10sfor the timed benchmark and let the 1,234-job benchmark finish naturally on both Linux and Windows. This removes the delayed process-wide kills and allows clean shutdown. Remove|| exit 0as well so Windows benchmark errors fail the job instead of being ignored.