Repository navigation
Restore negative duration validation in JobSnooze - #1529
Merged
bgentry merged 3 commits intoOct 23, 2026
Merged
Conversation
Contributor
|
Thanks! Do you want to throw a changelog entry in there too? |
fix lint error add changelog entry for negative duration validation
Contributor
Author
|
Added a changelog entry under Unreleased. Fixed and addressed the lint error. Thanks! |
bgentry
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1454
Summary
JobSnoozepreviously validated negative durations, but the validation was lost when the function was moved intoerror.goduring the job-executor refactor. This restores the documented behavior and adds public-API regression coverage.Changes
Testing
go test . -run '^TestJobSnooze' -count=1 -vgo test . -run '^TestJobSnooze$' -count=1The focused tests pass.