Repository navigation
fix(core): stop VMs on a shared sidecar answering each other's callbacks - #2089
Merged
Merged
Conversation
|
This PR was not deployed automatically as @eersnington does not have access to the Railway project. In order to get automatic PR deploys, please add @eersnington to your workspace on Railway. |
Contributor
📟 Pip-Boy ·
|
| package (linux-x64-gnu) | @latest |
base | this PR | Δ vs base | packages |
|---|---|---|---|---|---|
@rivet-dev/agentos-core |
326.2 MB | 326.3 MB | 326.3 MB | +2.0 KB (+0.0%) | 10 (0) |
@rivet-dev/agentos-node-pty |
7.6 KB | 18.0 KB | 18.0 KB | 0 | 1 (0) |
@rivet-dev/agentos-posix |
254.0 MB | 254.0 MB | 254.0 MB | +1.6 KB (+0.0%) | 7 (0) |
@rivet-dev/agentos-runtime-core |
254.0 MB | 254.0 MB | 254.0 MB | +1.6 KB (+0.0%) | 6 (0) |
@rivet-dev/agentos-sandbox |
363.9 MB | 363.9 MB | 364.0 MB | +2.0 KB (+0.0%) | 85 (0) |
@rivet-dev/agentos-toolchain |
130.8 KB | 141.2 KB | 141.2 KB | 0 | 2 (0) |
🧹 Rust dependencies · cargo deny + cargo shear
| check | new in this PR | fixed | existing on base |
|---|---|---|---|
| advisories | ✅ 0 | 0 | 28 |
| licenses | ✅ 0 | 0 | 0 |
| sources | ✅ 0 | 0 | 0 |
| bans | ✅ 0 | 0 | 0 |
| unused | ✅ 0 | 0 | 16 |
🦀 Binaries · publish Dockerfiles, --release
Base: main@c746292, the merge base.
| artifact | npm @latest |
base | this PR | Δ vs base |
|---|---|---|---|---|
agentos-native-sidecar linux-x64-gnu |
144.0 MB | 144.0 MB | 144.0 MB | −16 B (−0.0%) |
⏱ Timing
| job | wall time | slowest step |
|---|---|---|
zizmor |
9s | checkout · 3s |
changes |
34s | checkout · 29s |
native · linux-x64-gnu |
10m03s | Build with the publish Dockerfile · 9m30s |
footprint |
2m17s | Pack this commit · 44s |
hygiene |
57s | checkout · 24s |
⏭ self-test |
— | skipped |
report |
17s | setup-node · 4s |
🔭 Full CI trace for this commit
One OpenTelemetry trace of CI and Pip-Boy for 87c1b2f: every job and step, with the sizes above attached. Run after CI finishes.
pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha 87c1b2f0c75c2e57e0ba48ded3299a59d4a3e4adAdd --otlp <url> to send it to any OTLP/HTTP collector.
Agent instruction: From a rivet-dev/agentos checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VMs that share a sidecar can answer each other's callbacks. A guest in one VM can run a sibling VM's host function and get the sibling's result. The same bug reaches JS filesystem mounts and
agentosregistry commands.SidecarProcessnow keeps one handler per VM, set withsetVmSidecarRequestHandler. Requests with connection or session ownership still usesetSidecarRequestHandler.vm-1. Two sidecars in one process ran each other's host functions. The keys now include a per-transport ID.acalls a function thatbalso hasbanswersaanswersacalls it afterb.dispose()banswersaanswersacalls it, last sibling has no host functionsUnknown host functionaanswersareads/mnt/x/secret.txtsecret of bsecret of amkdiron the sibling's drivermain. A later VM only appeared to work because it used a sibling's driver.Related: #2029 proposed routing by VM ownership at the transport layer. Origin: #1531.