Repository navigation
fix(pi): resume a sleep that falls due while other work runs - #373
Merged
Merged
Conversation
|
This PR was not deployed automatically as @eersnington does not have access to the Railway project. In order to get automatic PR deploys, please add @eersnington to your workspace on Railway. |
📟 Pip-Boy ·
|
| package (linux-x64-gnu) | @latest |
base | this PR | Δ vs base | packages |
|---|---|---|---|---|---|
@rivet-dev/pi |
244.6 MB | 235.5 MB | 235.5 MB | +932 B (+0.0%) | 216 (0) |
@rivet-dev/sandbox-adapter |
113.8 KB | 113.8 KB | 113.8 KB | 0 | 1 (0) |
@sandbox-agent/cli-shared |
27.2 KB | 27.2 KB | 27.2 KB | 0 | 1 (0) |
@sandbox-agent/persist-indexeddb |
12.4 KB | 12.4 KB | 12.4 KB | 0 | 1 (0) |
@sandbox-agent/persist-postgres |
12.3 KB | 12.3 KB | 12.3 KB | 0 | 1 (0) |
@sandbox-agent/persist-rivet |
12.2 KB | 12.2 KB | 12.2 KB | 0 | 1 (0) |
@sandbox-agent/persist-sqlite |
12.3 KB | 12.3 KB | 12.3 KB | 0 | 1 (0) |
@sandbox-agent/react |
41.5 MB | 41.8 MB | 41.8 MB | 0 | 15 (0) |
acp-http-client |
6.7 MB | 6.7 MB | 6.7 MB | 0 | 3 (0) |
sandbox-agent |
30.9 MB | 30.9 MB | 30.9 MB | 0 | 8 (0) |
🧹 Rust dependencies
Skipped: this PR doesn't change any Rust code or dependencies.
🦀 Binaries
Skipped: this PR doesn't change any Rust code.
⏱ Timing
| job | wall time | slowest step |
|---|---|---|
changes |
19s | checkout · 14s |
zizmor |
22s | checkout · 9s |
footprint |
4m14s | Run pnpm --dir sandbox-agent install --frozen-lockfile · 1m33s |
⏭ hygiene |
— | skipped |
⏭ native · ${{ matrix.platform }} |
— | skipped |
⏭ self-test |
— | skipped |
report |
22s | checkout · 11s |
🔭 Full CI trace for this commit
One OpenTelemetry trace of CI and Pip-Boy for e1c63e5: every job and step, with the sizes above attached. Run after CI finishes.
pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha e1c63e52f5608b5eee56acfd99ec68993d62b6c7Add --otlp <url> to send it to any OTLP/HTTP collector.
Agent instruction: From a rivet-dev/agents checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.
eersnington
force-pushed
the
pi-wake-while-busy
branch
from
November 2, 2026 18:46
969e130 to
e1c63e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #372
With
onWake, Pi Durable keeps no timer for sleeps.wakeActor()inpackages/pi/src/runtime.tsreturned onactiveand ignoredat, so a sleep that fell due while other work ran resumed only at the next change to the wake value. A retry due in 2 s did not run within 25 s. This is a regression from #367.{ active: true, at }atignoredat{ active: false, at }c.schedule.at, then lets the actor sleepat, stays awakec.schedulewrite.atchanges.2 ** 31 - 1ms.setTimeoutfires at once past that limit, so a far-off sleep would spin. An early firing is safe: Pi runs a sleep only once its time has passed, and the wake re-arms.