Repository navigation
Fix reading of objects with custom streamer stored in TTree branch - #432
Merged
Merged
Conversation
Member
|
I closed and open again PR to restart CI jobs |
linev
approved these changes
Oct 26, 2026
linev
left a comment
Member
There was a problem hiding this comment.
I can confirm that correspondent code exists in ROOT
In TTreeReaderValue.cxx, line 771
} else if (brElement->GetType() == -1 && brElement->GetTypeName()) {
dict = TDictionary::GetDictionary(brElement->GetTypeName());
ResolveTypedef();
return brElement->GetTypeName();
}
Thanks for fixing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a class with its own Streamer is stored with
tree->Branch("lv", &lv)(TLorentzVector, TVector3, TGraph, TMatrixD, TVectorD ...) ROOT doesnt split it and writes each entry with the class streamer, so every entry starts with version and bytecount. jsroot ran the member streamers directly without reading that header, so all values came out shifted, for TLorentzVector fE was the same garbage number in every entry.for branches with fType -1 it now uses
buf.classStreamer(), which reads the header and still handles classes like TDatime that have none. this also fixesBranch("oa", "TObjArray", &arr)which threw a RangeError, and TList which came back empty.added demo/node/tree_tobject_test made with ROOT 6.40, it fails on current dev and passes with the fix.
this was assisted by ai