Repository navigation
[ntuple] add support for attribute merging - #23808
Open
silverweed wants to merge 6 commits into
Open
silverweed wants to merge 6 commits into
silverweed wants to merge 6 commits into
Conversation
silverweed
force-pushed
the
ntuple_merge_slow_4
branch
from
October 23, 2026 09:33
4ce2ebb to
6a207a0
Compare
Test Results 20 files 20 suites 3d 7h 49m 2s ⏱️ Results for commit 6f32942. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
ntuple_merge_slow_4
branch
from
October 26, 2026 09:01
6a207a0 to
4e9a850
Compare
This makes it easier to manage models' lifetime especially when attributes are added to the picture.
silverweed
force-pushed
the
ntuple_merge_slow_4
branch
2 times, most recently
from
October 27, 2026 07:58
01d75cc to
f1c216b
Compare
silverweed
force-pushed
the
ntuple_merge_slow_4
branch
from
October 27, 2026 08:05
f1c216b to
82ae349
Compare
This is required to support union-merging of attribute fields.
They cannot be read back at the moment. We might support them in the future
silverweed
force-pushed
the
ntuple_merge_slow_4
branch
from
October 27, 2026 08:07
82ae349 to
a117cca
Compare
silverweed
marked this pull request as ready for review
October 27, 2026 08:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #23739.
Adds support for RNTupleAttributes merging via custom MergeActions + slow merging.