Repository navigation
[ML] Move the RDataLoader tests to pytest - #23819
Draft
siliataider wants to merge 8 commits into
Draft
siliataider wants to merge 8 commits into
siliataider wants to merge 8 commits into
Conversation
siliataider
marked this pull request as draft
October 23, 2026 15:54
siliataider
force-pushed
the
rdataloader-tests-pytest
branch
from
October 23, 2026 16:09
e650945 to
38118fb
Compare
Test Results 24 files 24 suites 3d 22h 30m 29s ⏱️ Results for commit f98b9b8. ♻️ This comment has been updated with latest results. |
The JAX test needs it, like the PyTorch and TensorFlow tests need torch and tensorflow. Assisted-by: Claude Opus 5.5
The test classes no longer derive from unittest.TestCase, their names get the "Test" prefix fot pytest to collect, and their unittest assertions become the equivalent plain asserts. Assisted-by: Claude Opus 5.5
Each test now runs in its own temporary directory which pytest creates and cleans up. The next commits will use these. Assisted-by: Claude Opus 5.5
This remooves the try/except/finally blocks in favour of using the fixtures defined previously. Assisted-by: Claude Opus 5.5
Assisted-by: Claude Opus 5.5
…etrized test each The eager and lazy versions of the tests on one and on multiple RDataFrames were near copies of each other They are now merged into the sam etest class and use a parametrized fixture to switch between modes. The tests that only existed for one of the modes still only run for it, they just don't take the fixture. Assisted-by: Claude Opus 5.5
Each file is its own test, which only depends on the ML frameworks it uses. Assisted-by: Claude Opus 5.5
siliataider
force-pushed
the
rdataloader-tests-pytest
branch
from
October 26, 2026 09:55
38118fb to
f98b9b8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes:
Moves
ml_dataloader.pyfromunittesttopytestto make the tests shorter a,nd easier to read and to extend.The test logic is unchanged.
tmp_path, created and deleted by pytesttry/except/finallyblocks and theos.removes that existed only to delete temporary filesTestDataLoaderSingleDataframeandTestDataLoaderMultipleDataframes, which runn all of their tests twice (for both loading modes) using a parametrized fixtureChecklist: