Repository navigation
Conversation
silverweed
reviewed
Oct 27, 2026
When asimage disabled just build dummy library It will does nothing and will not try to link with libAfterImage Avoid complex workaround in different places where ASUtils are used now. Also better shows places where asimage is really required
No need for special workarounds when asimage is disabled - now it is done in the asutils intself
2 tasks done
Test Results 2 files 2 suites 5h 4m 20s ⏱️ Results for commit 64dc376. ♻️ This comment has been updated with latest results. |
Add optional mask argument It can be used by TASUtils::FromPixmap method It also resolves Windows problem where invocation of bitmap2asimage from ASUtils fails.
bellenot
approved these changes
Oct 28, 2026
bellenot
left a comment
bellenot
left a comment
Member
There was a problem hiding this comment.
I confirm this fixes the issue on Windows, so good for me, after addressing the other review comments and once the builds are green
silverweed
approved these changes
Oct 28, 2026
Configure gui library after ASImageUtils Add NO_GLOB_HEADERS to avoid multiple rules for same headers
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When asimage disabled just build dummy library
It will does nothing and will not try to link with libAfterImage
Avoid complex workaround in different places where ASUtils are used now.
Also better shows places where asimage is really required