Skip to content

chore: update Pushgate advisory review model - #162

Merged
asdolo merged 2 commits into
masterfrom
chore/update-pushgate-model
Oct 30, 2026
Merged

asdolo merged 2 commits into
masterfrom
chore/update-pushgate-model

Conversation

@devs-rootstrap

@devs-rootstrap devs-rootstrap commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Jira board reference:

  • No ticket: maintenance of the repository's push checks.

What does this do?

Updates the model used by Pushgate's advisory AI review in .pushgate.yml from the pinned claude-sonnet-4-20250514 to the CLI alias sonnet, which resolves to the current Sonnet release (today claude-sonnet-5-5) without further bumps.


Why did you do this?

The Claude CLI no longer serves claude-sonnet-4-20250514. Pushgate reports "model not found", turns that into a warning, and asks for an interactive confirmation. Any push without a terminal attached (scripts, automation, some IDE integrations) is refused at that point even though every blocking check passed. Pointing the advisory review at a model the CLI still serves lets the review run again instead of failing on every push.

Who/what does this impact?

Everyone who pushes to this repository with Pushgate installed. The blocking tools (type-check, eslint, lint, lint-translations, test) and the built-in policies are unchanged; only the advisory review's model changes.


Layer 2: Risk Classification

risk:low: a one-line config change to a local pre-push check.

How did you test this?

  • Confirmed claude --model sonnet -p ... answers (and reports claude-sonnet-5-5), and that Pushgate passes the configured model straight through as --model.

  • Not exercised through the pre-push hook itself: this branch was pushed from a fresh worktree without node_modules, where husky's hooks are not installed. A reviewer with Pushgate set up can confirm by pushing any branch after merging.

  • Tested on iOS

  • Tested on Android

  • Tested on a small device

  • Tested on a real device

  • Tested all flows related with this PR changes

  • Tested accessibility

  • Added tests


Notes:

The diff_size policy (max_changed_lines: 700, mode: warning) also needs an interactive confirmation when exceeded, so non-interactive pushes of larger branches are still refused. That is left as is here; worth a separate decision.

🤖 Generated with Claude Code

The advisory AI review in .pushgate.yml pointed at claude-sonnet-4-20250514,
which the Claude CLI no longer serves. Pushgate then reported "model not
found" and asked for an interactive confirmation on every push, which fails
in any non-interactive push. Point it at the current Sonnet model instead.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@devs-rootstrap devs-rootstrap added the risk:low Config, copy, minor UI tweaks. Low blast radius. label Oct 28, 2026
@devs-rootstrap
devs-rootstrap requested a review from a team as a code owner October 28, 2026 14:39
@devs-rootstrap
devs-rootstrap requested review from amaury901130, asdolo and fernandatoledo and a balanced review from Copilot October 28, 2026 14:39
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

💯 Test Coverage

Lines Statements Branches Functions
Coverage: 56%
56.23% (347/617) 59.18% (174/294) 48.76% (118/242)

😎 Tests Results

Tests Skipped Failures Errors Time
139 0 💤 0 ❌ 0 🔥 23.682s ⏱️
👀 Tests Details • (56%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files56.2359.1848.7656.9 
report-only-changed-files is enabled. No files were changed in this commit :)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the advisory model update intended to prevent model-not-found failures during non-interactive pushes.

No open issues 🎉

What changed in this PR

Overall Review: ai:clean

Updates Pushgate’s advisory review model to address the reported “model not found” failure that interrupts non-interactive pushes.

Changes:

  • Replaces claude-sonnet-4-20250514 with claude-sonnet-5-5.
  • Leaves blocking checks and built-in policies unchanged.

No actionable issues identified. End-to-end pre-push validation remains untested, as noted in the PR.

File Description
.pushgate.yml Updates the Claude model used for advisory AI reviews.

Review effort: Balanced

@label-pr-severity-rs label-pr-severity-rs Bot added the ai:clean No significant issues label Oct 28, 2026
Comment thread .pushgate.yml Resolved
Use the Claude CLI's `sonnet` alias instead of a pinned model id, so the
advisory review follows new Sonnet releases without config bumps.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@asdolo
asdolo merged commit 9612015 into master Oct 30, 2026
13 checks passed
@asdolo
asdolo deleted the chore/update-pushgate-model branch October 30, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai:clean No significant issues risk:low Config, copy, minor UI tweaks. Low blast radius.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants