Repository navigation
perf(fmt): reuse parent context in batch ignore matching - #593
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying rstack-cli with
|
| Latest commit: |
e79ac9c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b037d7a7.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-fmt-batch-parent.rstack-cli.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Batch ignore matching repeats ancestor-source lookups, parent-directory checks, and path-prefix construction for each entry in the same directory.
Changes
Reuse the applicable ignore sources, parent state, and path prefixes across each batch. Share rule evaluation and directory caching between individual and batch matches, and extend regression coverage for nested negation and cache invalidation after source updates.
Local measurements on a 56,631-file monorepo, using Node.js 22.16.0, 8 workers, no formatter cache, identical JS snapshots, and release native builds:
Native replay improved by 9.5%. File discovery and full checks showed no consistent improvement; the full check was faster in 3 of 6 rounds. Measurements exclude warmups and interleave variants: 18 native replay rounds, 12 fresh-process discovery runs, and 6 fresh-process full checks per variant. File/configuration hashes and diagnostics matched.
Validation: Rust formatting, Clippy, workspace tests, JS/native builds, and Rstack tests passed. A temporary differential harness also found no mismatches against the previous implementation across 2,164,583 comparisons.