Repository navigation
Conversation
…or 0.21
Removes `Runtime::Legacy`, which kept old-style scripts running as before and warned about what changes here, along with
`#evaluate_async`, `#evaluate_func`, `#evaluate_on` and `Utils::Deprecate`. Every call now takes the new path:
- a returned promise or thenable is awaited, and a rejection raises
- keywords are always named parameters, and mixing them with positional arguments raises `ArgumentError`
- a script of several statements raises `SyntaxError`, and one after a leading line break runs
- a thrown value that isn't an `Error` raises `JavaScriptError`
- `Node#evaluate` resolves nodes and dates instead of returning `{}`
Positional arguments keep working through `arguments[n]`.
route
force-pushed
the
feat/js-api-finish
branch
from
October 21, 2026 19:20
817cef6 to
4d305bf
Compare
route
force-pushed
the
feat/js-api-compat
branch
from
October 21, 2026 19:20
438925a to
087049a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step after #659, for 0.21. It's based on #659's branch, so this diff shows only the removal.
Removed
Frame::Runtime::Legacy: the old evaluation path, its change detection, andevaluate_async,evaluate_funcandevaluate_on.Utils::DeprecateandFERRUM_DEPRECATION_WARNINGS.Frame::Scripthelpers that only the old path used.Behavior in 0.21
Each of these was warned about in 0.20:
ArgumentError.SyntaxError. A script after a leading line break runs.ErrorraisesJavaScriptError.Node#evaluateresolves nodes and dates instead of returning{}.Positional arguments keep working through
arguments[n].