Repository navigation
feat(test): add Scenario::RustAnalyzer with a mock rust-analyzer component - #5141
Merged
Merged
Conversation
rami3l
force-pushed
the
test/rust-analyzer-scenario
branch
4 times, most recently
from
October 12, 2026 08:09
19de198 to
9168baa
Compare
rami3l
changed the title
ConstState::new()Scenario::RustAnalyzer with a mock rust-analyzer component
rami3l
force-pushed
the
test/rust-analyzer-scenario
branch
from
October 12, 2026 08:25
9168baa to
e4dfe85
Compare
rami3l
marked this pull request as ready for review
October 12, 2026 08:26
rami3l
commented
Oct 12, 2026
djc
approved these changes
Oct 12, 2026
rami3l
force-pushed
the
test/rust-analyzer-scenario
branch
from
October 12, 2026 09:14
8952a43 to
691e51b
Compare
rami3l
enabled auto-merge
October 12, 2026 09:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #5136.
So far, the
rust_analyzer_proxy_falls_back_external()test case is using an ugly hack that installsrlsand then renames it torust-analyzerto simulate a toolchain withrust-analyzerinstalled. This PR tries to get that setup properly done.This patch:
rust-analyzerproxy binary in the test fixture.Scenario::RustAnalyzerwhere the above proxy leads to an underlying mock binary.rust_analyzer_proxy_falls_back_external()test case around the new scenario.