Repository navigation
fix: report nightly build failures as Nightly, not Pre-release, in Slack - W-24680731 - #201
Merged
Merged
Conversation
The release_type sent to the Slack failure/success notification only ever checked the pre-release input, so nightly cron runs (which always pass pre-release: 'true') showed up as "Pre-release" failures -- indistinguishable from an actual marketplace pre-release promotion breaking. W-24680731
peternhale
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vscode-publish-extensions.yml's Slack success/failure notifications computedrelease_typepurely from thepre-releaseinput, with no "Nightly" optionpre-release: 'true', a routine nightly build failure showed up in Slack asrelease_type: "Pre-release"-- indistinguishable from an actual marketplace Pre-release promotion failinginputs.nightlyinto anis_nightlystep output and check it beforepre_releasewhen computingrelease_type, so nightly failures now report"Nightly"Test plan
nightly.ymlfromforcedotcom/salesforcedx-vscodeagainst this branch ref and confirm the dry-run log line showsRelease Type: Nightlyrelease_type: "Pre-release"is unchanged for the actual weeklypromote-to-prerelease.ymlflowW-24680731