Repository navigation
fix(verifiers): judge with the configured judge model in a rubrics verifier built in code - #339
Open
mpfaffenberger wants to merge 2 commits into
Open
mpfaffenberger wants to merge 2 commits into
mpfaffenberger wants to merge 2 commits into
Conversation
…rifier built in code A rubrics verifier read from a task took the [model.roles] judge model, but one constructed in code, as the A2A validator constructs its skill, snapshot and install rubrics, fell back to claude-sonnet-4-6 whatever the config said, so validating against an endpoint without that model failed those checks. Resolve the default in the constructor, so both paths take the judge role.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…cover the default model a judge role falls back to
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rubrics verifier read from a task took the [model.roles] judge model, but one constructed in code,
as the A2A validator constructs its skill, snapshot and install rubrics, fell back to
claude-sonnet-4-6 whatever the config said, so validating against an endpoint without that model
failed those checks. Resolve the default in the constructor, so both paths take the judge role.
Found while validating the Pydantic AI agent against an endpoint that serves no claude-sonnet-4-6. Adds
tst/unit/task_step/verifiers/test_rubrics_verifier_judge_model.py.
The PR appears safe to merge, with the previous test isolation issue fixed.Summary
Rubrics verifiers built in code now choose the configured judge model, matching verifiers read from tasks.
Reviews (2) · Last reviewed commit: "test(verifiers): give each judge-model t..." · Reviewed by Greptile