Skip to content

Make LP.name and Term.vartuple read-only in stubs - #1276

Merged
Joao-Dionisio merged 2 commits into
scipopt:masterfrom
Zeroto521:readonly-property
Oct 19, 2026
Merged

Joao-Dionisio merged 2 commits into
scipopt:masterfrom
Zeroto521:readonly-property

Conversation

@Zeroto521

@Zeroto521 Zeroto521 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Two other cdef readonly fields still had bare class-level annotations in scip.pyi

    class LP:
        name: str          # assignable per stub, raises at runtime

    class Term:
        vartuple: tuple[Variable, ...]   # same problem

Copilot AI balanced review requested due to automatic review settings October 19, 2026 10:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@Zeroto521 Zeroto521 changed the title Make LP.name and Term.vartuple read-only in stubs Make LP.name and Term.vartuple read-only in stubs Oct 19, 2026
@codecov

codecov Bot commented Oct 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.10%. Comparing base (9547994) to head (db4ddad).
⚠️ Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1276      +/-   ##
==========================================
+ Coverage   57.91%   58.10%   +0.19%     
==========================================
  Files          26       27       +1     
  Lines        5807     6025     +218     
==========================================
+ Hits         3363     3501     +138     
- Misses       2444     2524      +80     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Joao-Dionisio

Copy link
Copy Markdown
Member

Hey @Zeroto521 any other of these changes that you want to take care of before merging?

@Zeroto521

Copy link
Copy Markdown
Contributor Author

@Joao-Dionisio No more changes. This is a simple PR. All other readonly properties now use @property. LP.name and Term.vartuple are the only ones left.

@Joao-Dionisio
Joao-Dionisio added this pull request to the merge queue Oct 19, 2026
Merged via the queue into scipopt:master with commit e4381f7 Oct 19, 2026
7 checks passed
@Zeroto521
Zeroto521 deleted the readonly-property branch October 20, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants