Repository navigation
feat: add window_title to shpool list --json - #441
GeoffChurch wants to merge 1 commit into
Conversation
d52638e to
4baf484
Compare
|
I think you'll need to pull in shpool-vterm 0.2.7 (shell-pool/shpool-vterm#12) |
4baf484 to
68a0920
Compare
ethanpailes
left a comment
There was a problem hiding this comment.
I'd like to take a different approach to avoid double-storing the same data.
|
I just bumped the shpool-vterm version to 0.2.8, so you should be able to rebase and impl |
68a0920 to
d61f5d1
Compare
| fn handle_fetch_metadata( | ||
| spool: &dyn session_restore::SessionSpool, | ||
| request: Result<MetadataRequest, crossbeam_channel::RecvError>, | ||
| requests: &mut crossbeam_channel::Receiver<MetadataRequest>, |
There was a problem hiding this comment.
Draining other incoming requests immediately seems overly complicated. Let's just handled one at a time and use the top level dispatch loops for all incoming requests.
There was a problem hiding this comment.
Done.
Or, maybe we could at least continue; after shell.rs:541 (like maybe_switch does on shell.rs:523), which would let it handle bursts without the hacky inner loop. Burstiness is the typical case in my workflow since I have k running instances of the TUI app, and they all call shpool list --json at the same time to refresh their view whenever the events channel sends anything.
See discussion shell-pool#440
d61f5d1 to
b86aa4c
Compare
Issue Link
Discussion #440
AI Policy Ack
ack
Drafted with vibes, edited and tested with meat
This PR was:
Description
Adds
window_titleto the output ofshpool list --json:The use case is letting downstream tools show the user the window titles of their sessions. Many processes (shells, coding assistants, etc) send status information to the window title, which is traditionally visible in a terminal window/tab but in shpool is inaccessible without attaching to the session.
This change exposes the current title through
shpool list --jsonwithout attaching.