Repository navigation
Conversation
Collaborator
|
Thanks for the PR - a few comments/questions:
|
Author
|
Le 26 oct. 2026 à 02:32, Joe R. ***@***.***> a écrit :
Thanks for the PR - a few comments/questions:
The script pulls down pyinstaller, but does not pull any of the other pip packages that PySolFC requires - the installed version will not run. See the current Mac packaging script in GitHub actions or the AppVeyor script.
The script does not pull down the cardsets or any other packages.
The data folder layout does not seem to match what the normal PySolFC install uses.
I think we should be configuring the venv inside the script itself.
Hi! Thanks a lot for the review.
Indeed, the build worked on my machine because my local environment was already fully set up with the required dependencies and data files. You raised very good points to make the packaging script completely standalone!
I'm trying to update the script to:
Create and manage a dedicated venv internally.
Automatically install all required pip packages before building.
Clone/fetch the cardsets and place the data/ folder structure correctly for PyInstaller.
I'll push an updated commit as soon as it's ready. Thanks again for your guidance!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a build_macos.sh script to build a native standalone .app bundle on macOS (tested on Apple Silicon / macOS).
Key Changes
How to Test