Skip to content

Add standalone macOS app bundle creation script using PyInstaller - #601

Open
manu4bb9a wants to merge 1 commit into
shlomif:masterfrom
manu4bb9a:macos-apple-silicon-build
Open

manu4bb9a wants to merge 1 commit into
shlomif:masterfrom
manu4bb9a:macos-apple-silicon-build

Conversation

@manu4bb9a

Copy link
Copy Markdown

Summary

This PR introduces a build_macos.sh script to build a native standalone .app bundle on macOS (tested on Apple Silicon / macOS).

Key Changes

Handles runtime directory context (_MEIPASS vs working directory) so DataLoader correctly locates required assets (html/license.html, images/, cardsets/).

Sets sys.argv[0] dynamically to prevent asset lookup errors.

Bundles all necessary Python dependencies and PySolFC assets into dist/PySolFC.app.

How to Test

Clone the repository and set up a virtual environment.

Run ./build_macos.sh.

Open dist/PySolFC.app.

@joeraz

joeraz commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR - a few comments/questions:

  • The script pulls down pyinstaller, but does not pull any of the other pip packages that PySolFC requires - the installed version will not run. See the current Mac packaging script in GitHub actions or the AppVeyor script.
  • The script does not pull down the cardsets or any other packages.
  • The data folder layout does not seem to match what the normal PySolFC install uses.
  • I think we should be configuring the venv inside the script itself.

@manu4bb9a

manu4bb9a commented Oct 26, 2026 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants