Repository navigation
Expose Writing Tools panel presentation separately from editing sessions - #457
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Writing Tools chooser can be visible before an editing session begins, so clients cannot use the existing session callbacks alone to hide accessory UI.
Forward UIKit’s
UITextInput.willPresentWritingTools()anddidDismissWritingTools()through new defaultedTextViewDelegatecallbacks and exposeTextView.isWritingToolsPresented. Preserve the existing active-session and text synchronization semantics. Suppress duplicate notifications and clear presentation state when the input view leaves its window.Validation: 21 focused presentation, interaction, and active-session tests passed; changed-file SwiftLint and diff checks passed. Tests exercise the Objective-C callback bridge, chooser-only dismissal, both panel/session ending orders, and window detachment. Actual Apple Intelligence panel presentation on a physical device remains to be verified.
Companion RunestoneEditor #52 consumes this exact framework commit to hide its keyboard toolbar and cursor-position badge. Its remote-dependency build and 18 focused iPhone/iPad integration tests passed. Merge this framework PR first; the companion app PR is stacked on RunestoneEditor #46.