Repository navigation
Prevent bounds crashes when navigating unprepared wrapped lines - #459
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vertical cursor movement could query fragments beyond the portion of a long line prepared by viewport layout, triggering a RedBlackTree bounds assertion. Navigation now prepares the source and destination fragments before accessing them, including adjacent offscreen lines. Downward movement prepares only the requested fragments so a single Down key does not lay out an entire long line.
Validation: reproduced the crash before the fix (10000 out of bounds, valid range 0–84); 32 focused simulator tests pass, including four new regressions for partial layout, adjacent lines, and bounded layout work. Targeted SwiftLint and git diff --check pass.
Related to #411. The reproduced trigger is vertical navigation; the original rapid-typing sequence was not independently reproduced.