Repository navigation
Keep large-document navigation local and anchor upward scrolling - #461
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jumping to a distant line or range previously typeset every preceding line, blocking the editor on large documents. Navigation now measures the destination and a viewport-sized neighborhood while leaving unrelated heights estimated.
Preserve an overlapping visible line when measuring wrapped predecessors, applying height and scroll-offset corrections in the same layout transaction, including programmatic scrolling. Recover from overestimated wrapped tails before rendering, and use line-local coordinates for viewport typesetting. Prepare destination syntax colors and font metrics before calculating its scroll position so the first frame does not flash unhighlighted text or shift after highlighting.
Add nine navigation regressions covering distant jumps, wrapped interiors and ranges, anchored upward scrolling with contiguous fragment coverage, shrinking height estimates, token-font metrics, unwrapped horizontal reveal, and wrapping-mode changes. The example app can load a local fixture with Top/Bottom controls and timing logs; reproduction and simulator observations are in Example/NavigationTesting.md. No fixture or recordings are included.
Validation:
Limits: initial document parsing is unchanged, and a single exceptionally long logical line still requires sequential typesetting within that line. Scrollbar estimates can refine as more content is measured. Physical-device timing, interactive rotation, and scrolling with the full software keyboard were not verified; simulator captures are not a universal no-glitch guarantee.