Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultTheme rebuilt a named asset UIColor for every highlighted capture. Cache its 13 token colors in immutable static properties so repeated highlighting reuses the dynamic UIColor objects. Highlight-name parsing/fallback, nil colors, font traits and public API remain unchanged; custom Theme callbacks are untouched.
Validation:
Release full-line highlighting on iOS 27.2 Simulator, comparing this implementation against an unchanged copy of main's DefaultTheme at df9b56f in the same binary. One warmup per variant, seven measured trials, alternating order; parsing and initial attributed-string construction excluded. Median milliseconds:
The 1 MiB ranges were 1,551.012–1,944.452 ms before and 773.944–881.134 ms after. These are synchronous Simulator highlighting measurements, not physical-device/compositor timings. Dense lines remain expensive. This does not establish a RunestoneEditor speedup: its custom theme already caches colors. Fixtures and benchmark instrumentation remain local.