Skip to content

fix(ci): bound a stalled bun install and let the helm test probe wait for routing - #9409

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/ci-install-and-helm-test-flakes
Oct 28, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/ci-install-and-helm-test-flakes

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • bun install in the shared setup action now gets 3 minutes per attempt and up to 2 attempts (about 6.5 minutes worst case, inside the shortest caller's 10-minute job timeout). Bun already retries failed requests itself, but a registry connection that stalls without failing left the install waiting until the job timeout cancelled it. That cancelled a required integration shard and skipped a release's promote. Healthy installs finish within 146s cold (p99 94s across ~900 recent install steps). Only a stall (exit 124/137) is retried; any other failure still fails at once. This follows the bounded-attempt pattern other Bun monorepos use (kilocode, oh-my-pi, elizaOS)
  • The helm test probe retries each URL until a 60-second deadline. A pod turns Ready before every node routes its Service to it, so a single-shot probe sent the moment helm install --wait returns could be refused
  • The helm workflow moves the failure diagnostics after helm test and adds the realtime and test-pod logs, so a failed probe says which URL refused (--logs cannot be used: the hook's hook-succeeded delete policy removes a passing pod before helm reads its log)
  • Chart 1.11.9

Type of Change

  • Bug fix

Testing

  • Install loop run under bash with GNU timeout (Linux container) against a stub bun: success (1 call), lockfile error (fails at once, 1 call), stall then success (recovers on attempt 2), permanent stall (fails after 2), stall that ignores SIGTERM (killed after the grace period)
  • Rendered the test hook with helm template and ran the script through sh -n, then against a stub wget: recovers after refusals; fails at the deadline with exit 1
  • actionlint on helm.yml, helm lint on the chart

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Oct 28, 2026 4:15pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues remain.

Summary

Bounds stalled dependency installs and lets Helm connectivity tests wait for Service routing.

  • Shared CI setup gives stalled Bun installs a bounded retry.
  • Helm install checks wait for app services to route before failing.

The previous probe-duration finding is addressed. No new actionable issues were found.

Reviews (2) · Last reviewed commit: "fix(ci): fit the install retry inside ev..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread .github/actions/setup/action.yml Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread .github/actions/setup/action.yml Resolved
@waleedlatif1
waleedlatif1 merged commit 1f2299d into staging Oct 28, 2026
74 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/ci-install-and-helm-test-flakes branch October 28, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant