Skip to content

fix(search): inline action review and unify account menus - #9451

Merged
waleedlatif1 merged 4 commits into
stagingfrom
codex/search-integration-menus
Oct 29, 2026
Merged

waleedlatif1 merged 4 commits into
stagingfrom
codex/search-integration-menus

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Keep integration actions in one account-specific overflow menu and reuse the workspace credential detail layout. Offer Tool permissions only when the Assistant catalog supports the account; preserve separate app grants and reconnect the selected credential.
  • Review proposals inline in their initiating turn using the existing interaction card. Support field edits, individual Allow/Cancel, and counted batch decisions after the cards. Preserve keyboard focus, show saving feedback, and use labeled Allow/Ask/Block preferences.
  • Bind review, decisions, and execution claims to the current turn. Exclude expired proposals before pagination, reject inactive accounts, preserve the clicked batch snapshot, and recover saved decisions after missed notifications with bounded backoff.
  • Reuse the chat's interaction spacing while review owns the turn. Refresh docs and screenshots, including sticky heading offsets. Synchronize Search browser checks with URL updates and retain bounded diagnostics for browser rendering failures.

This follow-up does not change retrieval, ranking, model prompts, or the Assistant tool catalog.

Type of Change

  • Bug fix and UI improvement
  • Documentation

Testing

  • Root lint, 26 workspace type checks, all 61 audits, generated artifacts, and block-registry validation passed.
  • Root test command passed: 634 script tests and all 20 workspace tasks; the app passed 38,740 tests with eight existing skips. Used two workers to avoid local resource contention; test timeouts were unchanged.
  • All 16 native Assistant browser checks passed against the local API and database, including focus recovery, user navigation, mixed batch decisions, late arrivals, and zero provider execution. Focus regressions were observed before the fix; removing each intent guard independently makes its regression fail.
  • Final production CI passed 43 HTTP/browser checks: desktop inbox (13), Assistant actions (16), and organization Search (14), with no unexpected browser or server errors. Integration checks passed in both fresh-schema and migration lanes; mobile Chromium, mobile WebKit, and desktop live checks passed.
  • Docs production build and 24 responsive checks passed. Captured 47 screens, including real touch contexts at 320px and 390px, saving, errors, batch controls, and account menus. All screenshots use synthetic data.
  • Cleanup and test-audit reviews passed. Browser error assertions remain strict; diagnostics retain bounded samples and occurrence counts.

UI captures use synthetic accounts and content. Provider outcome examples are prepared fixtures; successful external provider delivery is not claimed by these tests.

Screenshots

Inline review

Account permissions

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (test-audit reviewed)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 29, 2026 11:19pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable new issues were found.

Summary

This PR moves Assistant action review into the conversation and combines account actions in one menu.

  • Assistant proposals appear in the conversation turn that started them.
  • Action reviews stay tied to the current turn and eligible proposals.
  • Integration accounts keep their actions in one menu.
  • Search browser checks wait for URL updates and capture bounded error details.
  • Documentation headings scroll clear of the sticky navigation.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Current Assistant turn] --> B[Load pending proposals]
  B --> C[Show inline review cards]
  C --> D[User edits or chooses a decision]
  D --> E[Copy the selected batch]
  E --> F[Save each decision]
  F --> G[Refresh pending proposals]
  G --> C
Loading

Reviews (4) · Last reviewed commit: "fix(search): polish inline action review..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 41 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/scripts/test-assistant-actions-e2e.ts Outdated
Comment thread apps/sim/lib/mothership/persistence/tool-permission/index.ts Outdated
Comment thread apps/sim/app/o/[organizationId]/integrations/utils.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 41 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 42 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 43 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit a0f47b1 into staging Oct 29, 2026
71 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-integration-menus branch October 29, 2026 23:46

This branch was successfully deployed

1 active deployment
Preview — fce18a7b Deployed Oct 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant