Repository navigation
fix(workflows): refuse new placements of sunset blocks in workflow edits - #9456
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummaryWorkflow edits now refuse new sunset blocks while keeping placed blocks editable.
Reviews (2) · Last reviewed commit: "test(workflows): cover sunset refusal wh..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
legacy/deprecated), e.g.tableinstead oftable_v2add, loop/parallelnestedNodeschildren,insert_into_subflow, and aneditthat switches a block's typeblock_not_allowedskipped item whose reason names the successor (use "table_v2" instead) and whosedetails.replacedBycarries it, so the agent self-correctsblocks listType of Change
Testing
lib/workflows/editing+lib/workflows/applicationsuites: 542 passedoperations.test.tsfail with each guard (add, nested, insert, type switch) reverted and pass with the fixbun run lint,check-block-registry.ts origin/stagingcheck:audits/ full suite left to CIChecklist
test-auditauthoring gate)