Skip to content

fix(search): unify navigation and preserve action review history - #9467

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/search-experience-polish
Oct 30, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/search-experience-polish

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Keep Search and Assistant in one header, with labeled New search / New chat actions and preserved drafts, filters, and conversation navigation.
  • Open integrations into account details with shared resource-header actions, isolated multi-account permissions, and explicit empty, disabled, and paused states.
  • Use compact approval previews and persistent receipts. Recover history by canonical turn identity, paginate and bound receipt requests, and retain retries when older action details cannot load.
  • Update the Search guides and screenshots.

Type of Change

  • Bug fix and UI improvement

Testing

  • Production app build; 40 browser/API checks against real local Postgres and Redis, including pending URL changes during both admission transports, old-response compatibility, selective/batch decisions, 64-action history, failed-history retry, disabled apps without accounts, account isolation, and mobile layouts.
  • Repository lint, all workspace type checks, all 62 audits, generated artifacts, and block-registry checks.
  • Full root bun run test (all 20 tasks passed) and documentation production build. Both edited guides checked at mobile, tablet, and desktop breakpoint boundaries.

Screenshots

Integration details and action review

Integration details

Tool permissions

Action review

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Oct 30, 2026 5:07am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The changes appear safe to merge, with no new actionable issues found.

Summary

Unifies Search and Assistant navigation, opens integrations in account details, and keeps action decisions visible as receipts.

  • Search and Assistant keep the same conversation while you switch views.
  • Assistant action reviews show compact proposals and lasting receipts.
  • Integration details show actions and permissions for the selected account.
  • The explicit-any audit baseline no longer lists the updated stream handler.

The earlier unnumbered “Disabled apps disappear” finding is fixed. Configured non-Search options now remain in the inventory, while separate checks still control connection actions.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Search[Search view and filters] --> Assistant[Assistant conversation]
  Assistant --> Admission[Server assigns chat ID]
  Admission --> URL[Build URL from current view]
  Assistant --> Review[Approve or cancel actions]
  Review --> Saved[Saved decisions and outcomes]
  Saved --> Receipts[Receipts in conversation history]
Loading

Reviews (2) · Last reviewed commit: "fix(search): preserve current view and u..." · Reviewed by Greptile

Comment thread apps/sim/app/o/[organizationId]/integrations/utils.ts

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 57 files

Confidence score: 4/5

  • In apps/sim/app/o/[organizationId]/integrations/utils.ts, omitting disabled or unready apps from the inventory means members can't inspect their unavailable state. Build the inventory from all assistant-provider options and filter readiness separately.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/app/o/[organizationId]/integrations/utils.ts">

<violation number="1" location="apps/sim/app/o/[organizationId]/integrations/utils.ts:193">
P2: Build the inventory from all assistant-provider options and filter readiness separately; this list omits disabled or unready apps, so members cannot inspect their unavailable state.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/assistant-actions/application/receipts.ts Outdated
Comment thread apps/sim/app/workspace/[workspaceId]/home/hooks/chat-url.ts Outdated
Comment thread apps/sim/app/o/[organizationId]/integrations/utils.ts
Comment thread apps/sim/app/o/[organizationId]/integrations/utils.ts
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 61 files

Confidence score: 3/5

  • In apps/sim/scripts/test-organization-search-e2e.ts, the URL assertion expects the opposite mode from the one just selected, so both loop iterations fail before admission resolves. Compare the URL with the selected mode.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/scripts/test-organization-search-e2e.ts">

<violation number="1" location="apps/sim/scripts/test-organization-search-e2e.ts:692">
P2: The click above activates `selectedMode`, as verified by `aria-current`; this assertion then requires the URL to use the other mode, so both loop iterations fail before admission resolves. Compare the URL with `selectedMode` instead.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/scripts/test-assistant-actions-e2e.ts
Comment thread apps/sim/scripts/test-organization-search-e2e.ts
@waleedlatif1
waleedlatif1 merged commit dff74b6 into staging Oct 30, 2026
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant