Repository navigation
fix(search): unify navigation and preserve action review history - #9467
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The changes appear safe to merge, with no new actionable issues found. SummaryUnifies Search and Assistant navigation, opens integrations in account details, and keeps action decisions visible as receipts.
The earlier unnumbered “Disabled apps disappear” finding is fixed. Configured non-Search options now remain in the inventory, while separate checks still control connection actions.
|
There was a problem hiding this comment.
1 issue found across 57 files
Confidence score: 4/5
- In
apps/sim/app/o/[organizationId]/integrations/utils.ts, omitting disabled or unready apps from the inventory means members can't inspect their unavailable state. Build the inventory from all assistant-provider options and filter readiness separately.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/app/o/[organizationId]/integrations/utils.ts">
<violation number="1" location="apps/sim/app/o/[organizationId]/integrations/utils.ts:193">
P2: Build the inventory from all assistant-provider options and filter readiness separately; this list omits disabled or unready apps, so members cannot inspect their unavailable state.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
1 issue found across 61 files
Confidence score: 3/5
- In
apps/sim/scripts/test-organization-search-e2e.ts, the URL assertion expects the opposite mode from the one just selected, so both loop iterations fail before admission resolves. Compare the URL with the selected mode.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/scripts/test-organization-search-e2e.ts">
<violation number="1" location="apps/sim/scripts/test-organization-search-e2e.ts:692">
P2: The click above activates `selectedMode`, as verified by `aria-current`; this assertion then requires the URL to use the other mode, so both loop iterations fail before admission resolves. Compare the URL with `selectedMode` instead.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Summary
Type of Change
Testing
bun run test(all 20 tasks passed) and documentation production build. Both edited guides checked at mobile, tablet, and desktop breakpoint boundaries.Screenshots
Integration details and action review
Checklist
test-auditauthoring gate)