Skip to content

fix(search): remove the extra assistant tools gate - #9468

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/assistant-tools-org-access
Oct 30, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/assistant-tools-org-access

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the separate rollout switch for Search Assistant integration tools across settings, discovery, request capabilities, and execution.
  • Keep organization access, personal account ownership, source restrictions, and action review enforced. Remove the retired setting from the docs.
  • Keep Search editing and submission disabled until hydration is ready, then autofocus the field. This prevents early edits from being appended to the initial query.

Type of Change

  • Bug fix

Testing

  • 170 focused tests and 59 real-Postgres/Redis action tests pass with no integration rollout setting.
  • Reproduced the missing permissions catalog and Assistant capability on the original code before fixing them.
  • Full root test suite, lint, type-check, block-registry check, test-type ratchet, and all 62 audits.
  • Production build, 23 action browser/API checks, and 17 Search browser checks with the rollout setting absent. Covers permissions, selective approvals, receipts, drafts, navigation, mobile layouts, and organization isolation.
  • Held-script hydration regression fails before the fix; independently removing the input, submit, or autofocus readiness change makes its assertion fail.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 30, 2026 7:25am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 15 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[High impact] The PR appears safe to merge; no new blocking issue was found.

Summary

Removes the separate rollout switch for Search Assistant integration tools while keeping the existing access checks.

  • Search Assistant can use eligible connected-account tools without a rollout switch.
  • The Search field waits for hydration before accepting edits or submissions.

No new actionable issues were found in the changes since the previous review. No previous review threads were supplied. Tests and browser checks were not run during this review.

Reviews (3) · Last reviewed commit: "fix(search): wait for hydration before e..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 16 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 19 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 9f3d3e1 into staging Oct 30, 2026
70 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/assistant-tools-org-access branch October 30, 2026 16:35

This branch was previously deployed

1 inactive deployment
Preview — c4d27e4e Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant