Repository navigation
chore(trigger): run tasks on the bun-1.4 runtime - #9481
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] No additional changes are required by this review; keep the author's stated merge delay. SummaryMoves Trigger.dev tasks to
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runtime: 'bun-1.4'(Bun 1.4.4), matching the app, realtime, and db images, which already run on Bun 1.4.4@trigger.dev/sdk,core,buildand the CItrigger.devCLI from 4.7.6 to 4.8.2, the first release withbun-1.4nodeBinary()build extension: thebun-1.4image ships nonode, but the isolated-vm sandbox and the Oracle worker run asnodechild processes. It copies Node 24.22.1 from a digest-pinnednode:24.22.1-bookworm-slim, the same version asdocker/app.Dockerfile. Because the layer adds image instructions, Trigger.dev builds the install stage from this base too, soisolated-vm's install script runs against that Node. Deploy only;trigger devuses the localnodedistrustCompromisedRoots()stays ininit. Under Bun 1.4.4 the roots are already absent, so it does nothing; docs updatedHold the merge until 2026-11-05 ~13:36 UTC.
@trigger.dev/*@4.8.2was published 2026-10-29, andbunfig.toml's 7-dayminimumReleaseAgecool-down has not elapsed. CI still installs because the frozen-lockfile install does not re-check release age, so the hold is policy, not a CI failure. The gate is left as is.Type of Change
Testing
trigger.dev@4.8.2generateContainerfile(bun-1.4+ this layer): baseCOPYs Node and checks its version; the install stage buildsFROM baselinux/amd64fromtriggerdotdev/bun:1.4-bookworm(the CLI's pinned digest), usingbun installwith the real externals (isolated-vm6.2.0,sharp,@napi-rs/canvas,pdfjs-dist):spawn('node', ['--no-node-snapshot', …])→ Node v24.22.1, andisolated-vmevaluates1+1 = 2sharprenders a PNG, and@napi-rs/canvasandpdfjs-distload under Bunbiome checkon changed files; type-check, audits, and tests run in CIChecklist
test-auditauthoring gate)