Skip to content

fix(search): trace live provider latency and partial failures - #9482

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/search-provider-diagnostics
Oct 30, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
codex/search-provider-diagnostics

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Start diagnostics at the shared live-search application boundary so dashboard searches are traced alongside Copilot and MCP.
  • Record per-provider stage timings, bounded outbound request outcomes, safe failure codes, and the specific causes of partial coverage. Include late preview completions without delaying search.
  • Preserve search results, authorization, ranking, retries, and deadlines. Keep query text, content, credentials, and raw provider errors out of diagnostics.

Type of Change

  • Bug fix

Testing

  • Passed root lint, type-check, all 62 audits, generated-artifact checks, and block-registry validation.
  • Independently reviewed concurrency, cancellation, privacy, response decoding, partial coverage, and late previews.
  • Added regression coverage for isolated provider traces, redaction, bounded records, cancellation, and late completion. All CI checks passed. The desktop-inbox job passed on an isolated retry with zero browser runtime errors; its initial streamed-404 error artifact is preserved for follow-up.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 30, 2026 9:07pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the prior date-filter finding is fixed and no new actionable issues were found.

Summary

Adds shared live-search diagnostics for Dashboard, Copilot, and MCP, with per-account timings, bounded request records, safe failure codes, and late-preview outcomes.

  • Live searches now trace each provider account and its coverage.
  • Provider requests now leave bounded records with safe failure details.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Dashboard, Copilot, MCP] --> B[Shared search diagnostics]
  B --> C[Provider account diagnostics]
  C --> D[Search, verification, previews]
  D --> E[Bounded request records]
  C --> F[Provider summary]
  B --> G[Search summary]
  E --> H[Late completion records]
Loading

Reviews (2) · Last reviewed commit: "fix(search): report every supported date..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 5f2b8cd into staging Oct 30, 2026
57 of 58 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-provider-diagnostics branch October 30, 2026 21:12

This branch was previously deployed

1 inactive deployment
Preview — 9c7221ab Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant