Repository navigation
feat(sim-links): organization Sim links (go links) with sim/<name> redirects - #9484
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
All reported issues were addressed across 42 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
[Medium impact] The PR appears safe to merge; no actionable issues remain from this review. SummaryAdds organization-wide Sim Links with editable destinations, variable values, access settings, visit counts, audit entries, and an organization feature flag.
|
…le saving, announce access hint
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
…w, decode typed paths
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
…age, format migration meta
|
@cubic-dev-ai review this PR |
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 42 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…its index, final cleanup
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 44 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
…umn class, stable audit poll
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 49 files
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
…racters, and off-site defaults
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 49 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
Summary
sim/<name>links that take everyone in an organization to a destination. New Sim Links page in the org sidebar, available to Search and regular seats alikesim.ai/sim/<name>[/values]resolves the viewer's organization link and redirects; signed-out visitors sign in and continue, and an unknown name offers to create itsim/Q4-goals=sim/q4goals); plain links append extra path segments,{*}variable links fill values in order with an optional default destination{*}can never change the origin, so a value can't redirect off-sitesim_linktable (additive migration), org operations throughdefineAuthorizedOrganizationUseCase,sim_link.created/updated/deletedaudit entriessim-linksfeature flag (SIM_LINKSfallback off AppConfig); routes 403 and the page/resolver 404 while offsim jira/123, pushable to managed browsers viaSiteSearchSettings) works todaySettingsListPaginationreused by Search sources and Sim Linkssearch/sim-links(including the address-bar shortcut), audit-log action tablehttp://sim/*to<origin>/sim/*so typingsim/handbookin the address bar worksType of Change
Testing
lib/sim-links/destination.test.ts: origin escape via{*}, value encoding, missing values, default destination, http-only; each guard reverted to confirm its cases go redscripts/test-sim-links-e2e.ts(12/12 against a local app + disposable DB, wired into the SCIM HTTP E2E group): sign-in redirect, case/punctuation resolution, appending, variable fill with hostile values, validation, conflict, unlisted visibility, restricted edits, access-setting changes by non-owners, cross-org isolation, visit counting and most-used order, encoded and spaced values, delete, audit entriescheck:migrations,drizzle-kit generate(no drift),api-validation:strict,boundaries,permission-group-enforcement,principal-kind-parity,application-graph,react-query,client-boundary,file-names,source-conventions,comment-hygiene,utils,test-patterns,script-tests, biomeChecklist
test-auditauthoring gate)