Skip to content

improvement(sim-links): show each link's destination favicon - #9489

Merged
waleedlatif1 merged 1 commit into
stagingfrom
feat/sim-links-favicons
Oct 31, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
feat/sim-links-favicons

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Each Sim link row shows its destination's favicon instead of a generic link glyph, so links are recognizable at a glance
  • Reuses the shared faviconUrl helper and the source-chip pattern (referrerPolicy='no-referrer', per-hostname error fallback); a link whose favicon can't load falls back to a globe
  • The host comes from simLinkOrigin, so variable links (https://github.com/{*}) show their fixed site's icon

Type of Change

  • Improvement

Testing

  • Headless browser QA in light and dark themes with links to GitHub, Glean docs, Atlassian, Okta, and an internal host with no public favicon: each loads its favicon; the unknown host shows the generic globe
  • biome, check:react-query, check:client-boundary, check:file-names, check:source-conventions, check:comment-hygiene, check:utils, check:boundaries, check:source-text, check:test-patterns

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 31, 2026 12:17am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Sim link rows now show the destination favicon instead of a generic link icon.

  • Sim link rows show the icon for each destination site.

No actionable issues found.

Reviews (1) · Last reviewed commit: "improvement(sim-links): show each link's..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit c63e93e into staging Oct 31, 2026
69 checks passed
@waleedlatif1
waleedlatif1 deleted the feat/sim-links-favicons branch October 31, 2026 02:11

This branch was previously deployed

1 inactive deployment
Preview — 5a992df8 Deployed Oct 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant