Repository navigation
improvement(sim-links): cleanup and simplify pass on the resource layout - #9492
Merged
Merged
Conversation
…nk, shared columns, lazy favicons, sort-reversal e2e check)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
[Medium impact] The PR appears safe to merge; no actionable new issues were found. SummaryThis PR simplifies the Sim Links resource page.
No actionable new issues were found in the changes since the previous review. No previous finding threads were supplied. Reviews (2) · Last reviewed commit: "improvement(sim-links): quieter link edi..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #9491: the
/cleanupand/simplifypass over the Sim Links resource-layout rewrite.columns.ts, shared by the page and its loading chrome so the skeleton can't drift from the tablelistedNamestakes query params as a recordLink editor
{*}and naming detailssim/is dropped, spaces and slashes become hyphens, and characters a name can't hold are removed (toSimLinkName, built from the same character set the server validates)Type of Change
Testing
scripts/test-sim-links-e2e.ts12/12 against a local app + disposable DBTeam Handbook!→Team-Handbook, typedsim/okta→okta,q4 goals/2026→q4-goals-2026), no page errorslib/sim-linksunit tests (37), biome,check:react-query,check:client-boundary,check:boundaries,check:file-names,check:source-conventions,check:comment-hygiene,check:utils,check:test-patterns,check:source-textChecklist
test-auditauthoring gate)