Skip to content

improvement(sim-links): cleanup and simplify pass on the resource layout - #9492

Merged
waleedlatif1 merged 2 commits into
stagingfrom
improvement/sim-links-cleanup
Oct 31, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
improvement/sim-links-cleanup

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #9491: the /cleanup and /simplify pass over the Sim Links resource-layout rewrite.

  • The row menu stores the link id and reads the live link from the list, so a refetch while the menu is open (another member's edit, a permission change, a delete) can't leave it acting on a stale copy
  • Columns, the New link action, and the search placeholder live in one columns.ts, shared by the page and its loading chrome so the skeleton can't drift from the table
  • Favicons load lazily and decode asynchronously, so rows below the fold don't fetch up front
  • Small simplifications: one trimmed search value, a single delete guard in the menu, and the name cursor's comparison chosen alongside the sort direction
  • E2E: Z to A is asserted as the default order reversed, rather than against a copy of the server's name normalizer; listedNames takes query params as a record

Link editor

  • Helper text under Destination URL, Name, and Access is gone; a Learn more footer action (the modal docs pattern) opens the Sim Links docs, which now hold the {*} and naming details
  • The Name field shapes input as it's typed instead of rejecting it on save: a leading sim/ is dropped, spaces and slashes become hyphens, and characters a name can't hold are removed (toSimLinkName, built from the same character set the server validates)
  • Access checkboxes read Hide from the Sim Links page and Only you and admins can edit; the docs describe them by those labels and the Unlisted / Restricted column values

Type of Change

  • Improvement

Testing

  • scripts/test-sim-links-e2e.ts 12/12 against a local app + disposable DB
  • Headless browser QA: table, row menu → edit modal, sort by opens, no-results state, empty state, name shaping (Team Handbook! → Team-Handbook, typed sim/okta → okta, q4 goals/2026 → q4-goals-2026), no page errors
  • lib/sim-links unit tests (37), biome, check:react-query, check:client-boundary, check:boundaries, check:file-names, check:source-conventions, check:comment-hygiene, check:utils, check:test-patterns, check:source-text

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…nk, shared columns, lazy favicons, sort-reversal e2e check)
@vercel

vercel Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 31, 2026 2:17am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable new issues were found.

Summary

This PR simplifies the Sim Links resource page.

  • The row menu uses the current link from the list.
  • Sim Links search and sorting use simpler shared values.
  • The Sim Links editor and help use clearer name and access guidance.
  • The Sim Links page and loading screen share their table setup.
  • Sim Links defer loading and decoding destination favicons.

No actionable new issues were found in the changes since the previous review. No previous finding threads were supplied.

Reviews (2) · Last reviewed commit: "improvement(sim-links): quieter link edi..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 10 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 7027fd5 into staging Oct 31, 2026
73 of 74 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/sim-links-cleanup branch October 31, 2026 02:23

This branch was successfully deployed

1 active deployment
Preview — dde328aa Deployed Oct 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant