Skip to content

fix(docs): simplify selection and verify media interactions - #9493

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/docs-sidebar-selection
Oct 31, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/docs-sidebar-selection

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the sidebar selection edge while preserving selected backgrounds and keyboard focus.
  • Verify image-viewer reopening, dismissal, and focus restoration end to end.
  • Compare every repaired citation and embedding by row identity instead of assuming database result order.

Type of Change

  • Bug fix

Testing

Focused Biome 2.0.6 and diff checks passed. Read-only cleanup and test audits passed. Full builds, generators, audits, PostgreSQL lifecycle, and Chromium/WebKit E2E checks run in CI; results pending.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 31, 2026 2:18am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The reviewed changes appear safe to merge.

Summary

Removes the sidebar selection edge while keeping selected backgrounds and keyboard focus styles.

  • The selected docs page keeps its background without a dark-mode edge.
  • The media viewer test checks reopening and focus after every dismissal.
  • The database repair check compares citations by row identity.

No new actionable issues were found. No previous review threads were supplied. Browser and database tests were not run during this review.

Reviews (2) · Last reviewed commit: "fix(docs): wait for actionable lightbox ..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 873489c into staging Oct 31, 2026
43 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/docs-sidebar-selection branch October 31, 2026 02:23

This branch was successfully deployed

1 active deployment
Preview — 66fb724d Deployed Oct 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant